Update to ops 2.10 #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tonyandrewmeyer could you rebase this branch? I don't think there was any reason why this doesn't use ops 2.x other than major rev pinning to prevent catastrophes of APIs changing. |
Done (well, it was a merge because I lazily just used the GitHub UI's sync tool, but I assume this would be squashed so it would all work out the same in the end). |
|
#9 will likely incorporate this same change. Thanks for helping us though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'd be great to move this charm to ops 2.x (and if doing so, then 2.10 would be a good target for now).
All the tests pass for me locally when doing this, so I'm not sure what the motivation was behind pinning to 1.x. It could be that there are issues that aren't caught by the tests that mean more needs to be done here. If you need help moving to 2.x, please reach out to @canonical/charm-tech and we'd be happy to help.